Skip to content

Conversation

@filipeom
Copy link
Member

@filipeom filipeom commented Jan 5, 2026

Seems to improve performance a bit. Not sure if it is just by not using tuples or because of the hash functions of the other modules.

@filipeom filipeom requested a review from a team as a code owner January 5, 2026 09:22
Seems to improve performance a bit. Not sure if it is just by not using
tuples or because of the hash functions of the other modules.
@filipeom filipeom force-pushed the filipe/reduce-allocs-hc branch from d2ae545 to 889d4c9 Compare January 5, 2026 11:52
@hra687261
Copy link
Contributor

Out of curiosity, is there a simple way to measure the effect on performance of "small changes"?

@filipeom
Copy link
Member Author

filipeom commented Jan 5, 2026

Out of curiosity, is there a simple way to measure the effect on performance of "small changes"?

At the moment we don't have enough observability to do so.

What I'm doing in our symbolic execution engine for javascript is roughly looking at execution time and also the flamegraph traces of the execution. But for programs that I know suffer from hashconsing issues.

For example, this PR improves the following javascript program execution time by 3 seconds. Not a big gain, but it is something 😅

var i = 0;
var limit = 5000;
var res = 0;
while (i < limit) {
  res += i;
  i += 1;
}
console.log(res);

In the future I want to add some tracing to smtml. That way it's easier to measure the effects of small changes. But right now I'll try to pick the low hanging fruit first by looking at flamegraph 😅

@filipeom filipeom merged commit b053eac into main Jan 5, 2026
11 checks passed
@filipeom filipeom deleted the filipe/reduce-allocs-hc branch January 5, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants